This repository was archived by the owner on Mar 18, 2024. It is now read-only.
fix: enable json flag for pool fetch command#1404
Merged
azlam-abdulsalam merged 3 commits intoSep 16, 2023
Merged
Conversation
Contributor
Author
|
Hi @azlam-abdulsalam, is this something that could make it into a new version? We're trying to update our CICD pipelines to this newer version but we're missing the following functionality. The older sfdx command |
Contributor
|
Thanks @RobinWeymans , will have a look and merge it in. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1404 +/- ##
=======================================
Coverage 46.87% 46.87%
=======================================
Files 70 70
Lines 2658 2658
Branches 308 308
=======================================
Hits 1246 1246
Misses 1384 1384
Partials 28 28 ☔ View full report in Codecov by Sentry. |
|
Reviewpad Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--jsonflag is currently not available for thesf pool fetchcommand while it is available for other pool commands. This PR adds the json flag and suppresses non-json log output.Checklist
All items have to be completed before a PR is merged