This repository was archived by the owner on Mar 18, 2024. It is now read-only.
fix: display login URL instead of instance URL for scratch orgs#1432
Merged
azlam-abdulsalam merged 1 commit intoOct 26, 2023
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1432 +/- ##
=======================================
Coverage 46.86% 46.86%
=======================================
Files 70 70
Lines 2665 2665
Branches 313 313
=======================================
Hits 1249 1249
Misses 1386 1386
Partials 30 30 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@azlam-abdulsalam I saw your comment in the code about required unification of |
Contributor
|
Awesome thanks @michallachowski , keep them coming |
azlam-abdulsalam
approved these changes
Oct 26, 2023
azlam-abdulsalam
left a comment
Contributor
There was a problem hiding this comment.
Thanks @michallachowski
|
Reviewpad Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects a bug that appears when
--orginfoparameter is provided forsfpowerscripts orchestrator:validatecommand. The method that generates markdown with org info details is failing due to undefinedscratchOrg.instanceURLproperty - as a result it is completely blocking ability to validate changes.I think we can simply replace that by
loginURL, which is populated and contains contains expected info.Checklist
All items have to be completed before a PR is merged