This repository was archived by the owner on Mar 18, 2024. It is now read-only.
fix: validation of artifact source repo#812
Merged
Merged
Conversation
Fix validation logic used for checking if artifacts belong to the same source repo, such that auth info or different protocol does not impact validity.
Codecov Report
@@ Coverage Diff @@
## develop #812 +/- ##
========================================
Coverage 66.22% 66.22%
========================================
Files 46 46
Lines 1593 1593
Branches 341 346 +5
========================================
Hits 1055 1055
+ Misses 538 505 -33
- Partials 0 33 +33
Continue to review full report at Codecov.
|
Artifacts from the same source repo, but specified in different protocol will not be considered from the same repo.
Update error messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix validation logic used for checking if artifacts belong to the same source
repo, such that auth info does not impact validity.
Closes #811