Thanks to visit codestin.com
Credit goes to github.com

Skip to content

UPDATE add manageable dataobject support#14

Merged
muskie9 merged 1 commit into
dynamic:1.0from
muskie9:update/manageableSupport
Jul 25, 2017
Merged

UPDATE add manageable dataobject support#14
muskie9 merged 1 commit into
dynamic:1.0from
muskie9:update/manageableSupport

Conversation

@muskie9
Copy link
Copy Markdown
Member

@muskie9 muskie9 commented Jul 25, 2017

I've added a check for use_id as a config option. This allows the link to be either the URLSegment or the record's ID.

@muskie9 muskie9 requested a review from jsirish July 25, 2017 14:37
Copy link
Copy Markdown
Member

@jsirish jsirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 25, 2017

Codecov Report

Merging #14 into 1.0 will increase coverage by 0.84%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.0      #14      +/-   ##
==========================================
+ Coverage   63.28%   64.12%   +0.84%     
==========================================
  Files           1        2       +1     
  Lines         128      131       +3     
==========================================
+ Hits           81       84       +3     
  Misses         47       47
Impacted Files Coverage Δ
tests/ViewableTestObject.php 100% <100%> (ø)
src/ViewableDataObject.php 63.56% <100%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c87762...cacc75e. Read the comment docs.

@muskie9 muskie9 merged commit 1137258 into dynamic:1.0 Jul 25, 2017
@muskie9 muskie9 deleted the update/manageableSupport branch July 25, 2017 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants