Thanks to visit codestin.com
Credit goes to github.com

Skip to content

一些改进 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

一些改进 #11

wants to merge 4 commits into from

Conversation

koboshi
Copy link

@koboshi koboshi commented Jan 3, 2014

include_once改为require
避免重复包含和嵌套引起bug
错误信息显示与否现在可通过常量DEBUG控制

@picasso250
Copy link
Contributor

value || action;
这种写法是不推荐的。应该让自己的写法更加清晰。
http://programmers.stackexchange.com/questions/109138/is-it-bad-practice-to-use-short-circuit-evaluation-instead-of-an-if-clause

error_reporting 应该一直是 E_ALL^E_NOTICE，不应该可以通过配置关闭。
http://www.v2ex.com/t/67309

@lichunqiang
Copy link

include_once 如果该文件已经包含，则不会再次包含。

@koboshi
Copy link
Author

koboshi commented Jan 4, 2014

入口文件用once(或者过于依赖once)并不是一个好主意

@picasso250
Copy link
Contributor

@lichunqiang 我同意 @koboshi 关于 include_once 的意见。
http://www.laruence.com/2012/09/12/2765.html

picasso250
picasso250 reviewed Jan 5, 2014
View reviewed changes
_lp/core/controller/core.class.php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

让原本的代码保持原本的样子，尤其是代码风格。

@lichunqiang
Copy link

@picasso250 @koboshi
至少lp里使用了once，如果是自己写东西，当然不使用once，但是作为框架级别的，不能保证每个使用者都会注意到文件的引用关系。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koboshi @picasso250 @lichunqiang @4tj