widget/tooltip: Check if the parent Visibility before rendering #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've changed the implementation as the one I had did not work for more complex examples (my game) so the current one works and makes much more sense :). I'll check later for the #162 as I think it's the same so I'll be opening a new PR for that if it's the case. |
Contributor
Author
|
This last commit uses the new function in places in which that same logic was repeated, though the function checks parents and the other places did not I think it fits. If not I can just remove the commit :) |
So we do not render ToolTips of hidden parents
mcarpenter622
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok so this makes the example I wrote work, but I would like @mcarpenter622 to take a deeper look just to check if it's actually accurate or I missed something else totally.
I'll check if this works on my game as it has much more complex ToolTips.
Closes #177