fix: avoid errors when executing unfinished operations after dispose#1031
Merged
Conversation
|
@plainheart Can you review this pr? |
plainheart
requested changes
Dec 4, 2023
Collaborator
plainheart
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I would prefer adding a flag _disposed and checking it before invoking the instance methods, as ECharts does.
https://github.com/apache/echarts/blob/master/src/core/echarts.ts#L1168-L1185
…dispose Signed-off-by: yechunxi <[email protected]>
Contributor
Author
Thank you, your suggestion will be better. Based on the suggestions you gave me, I implemented it again. I hope to review it |
plainheart
approved these changes
Dec 20, 2023
|
@plainheart Are you able to release a new version since this has been merged in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A chart is performing certain operations. After the operation, it will be refreshed and calling flush. At this time, the instance has been disposed, an error will appear. such this issue and in react native echart issue