Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[RFR] 2.0.0#22

Merged
KittyGiraudel merged 5 commits into
masterfrom
feature/2.0.0
Apr 15, 2016
Merged

[RFR] 2.0.0#22
KittyGiraudel merged 5 commits into
masterfrom
feature/2.0.0

Conversation

@KittyGiraudel
Copy link
Copy Markdown
Contributor

  • Default behaviour is now collapsed by default.
  • Expanded by default behaviour can be done by adding data-a11y-toggle-open attribute on target.
  • Rewritten script to improve performance and code quality.

Ping @smartmike, @peterjmag.

Comment thread a11y-toggle.js
if (el.nodeType === 1 && el[matches](selector)) {
return el;
while (element) {
if (element.nodeType === 1 && element.hasAttribute('data-a11y-toggle')) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smartmike
Copy link
Copy Markdown

LGTM

@KittyGiraudel KittyGiraudel merged commit 2db3078 into master Apr 15, 2016
@KittyGiraudel KittyGiraudel deleted the feature/2.0.0 branch April 15, 2016 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants