fix: keep selection on formatting#372
Conversation
|
@SunsetTechuila Sorry for the delay. It seems like the main maintainer has stopped maintaining it for quite a while. I can help with the review, but I never worked on this repo before today and don't know VSCode much. Could you add a bit more context to the original post so I can understand what this is doing/changing? Also, is there a relevant test that you can add? |
|
before (autosave on change is on, and I'm not pressing Enter): Recording.2025-01-30.173214.mp4after (the active line changes only when I press Enter): Recording.2025-01-30.173509.mp4 |
|
Why doesn't the current solution work? I have no idea. VSCode APIs are poorly documented, and after some experimentation I think this is a bug |
Workspace.applyEdit for applying changesCo-authored-by: Hong Xu <[email protected]>
|
Could you take a look at this failure? https://github.com/editorconfig/editorconfig-vscode/actions/runs/13062880401/job/36449691603 It looks like the Windows test became flaky after this PR. |
tscw/o errors (same asnpm run compile).npm run lintw/o errors.fixes #330 and its duplicates