Sourcery refactored master branch #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-39
to
+44
| _credentials = open(os.path.join(root, 'build', 'credentials.json'), 'r') | ||
| pio.kaleido.scope.mapbox_access_token = json.load(_credentials)['MAPBOX_ACCESS_TOKEN'] | ||
| _credentials.close() | ||
|
|
||
| with open(os.path.join(root, 'build', 'credentials.json'), 'r') as _credentials: | ||
| pio.kaleido.scope.mapbox_access_token = json.load(_credentials)['MAPBOX_ACCESS_TOKEN'] | ||
| ALL_MOCKS = [os.path.splitext(a)[0] for a in os.listdir(dirIn) if a.endswith('.json')] | ||
| ALL_MOCKS.sort() | ||
|
|
||
| if len(args) > 0 : | ||
| allNames = [a for a in args if a in ALL_MOCKS] | ||
| else : | ||
| allNames = ALL_MOCKS | ||
|
|
||
| allNames = [a for a in args if a in ALL_MOCKS] if len(args) > 0 else ALL_MOCKS |
There was a problem hiding this comment.
Lines 39-131 refactored with the following changes:
- Use
withwhen opening file to ensure closure (ensure-file-closed) - Replace if statement with if expression (
assign-if-exp) - Simplify sequence length comparison (
simplify-len-comparison) - Hoist statements out of for/while loops (
hoist-statement-from-loop) - Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Replace range(0, x) with range(x) (
remove-zero-from-range)
Comment on lines
-13
to
+14
| _credentials = open(os.path.join(root, 'build', 'credentials.json'), 'r') | ||
| pio.kaleido.scope.mapbox_access_token = json.load(_credentials)['MAPBOX_ACCESS_TOKEN'] | ||
| _credentials.close() | ||
|
|
||
| with open(os.path.join(root, 'build', 'credentials.json'), 'r') as _credentials: | ||
| pio.kaleido.scope.mapbox_access_token = json.load(_credentials)['MAPBOX_ACCESS_TOKEN'] |
There was a problem hiding this comment.
Lines 13-62 refactored with the following changes:
- Use
withwhen opening file to ensure closure (ensure-file-closed) - Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.26%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!