fix(forest): properly handle createStore in classList#1286
Open
pijng wants to merge 1 commit intoeffector:masterfrom
Open
fix(forest): properly handle createStore in classList#1286pijng wants to merge 1 commit intoeffector:masterfrom
pijng wants to merge 1 commit intoeffector:masterfrom
Conversation
In forect, when creating the css class store with createStore directly — without additional call to restore — the initial value was not being applied correctly to the classList. The fix creates a new store with the correct initial value to handle updates, ensuring the initial state is properly set and all the further updates to the class store is being applied. Fixes effector#965
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In forect, when creating the css class store with createStore directly — without additional call to restore — the initial value was not being applied correctly to the classList.
The fix creates a new store with the correct initial value to handle updates, ensuring the initial state is properly set and all the further updates to the class store is being applied.
Fixes #965
Conventions