fix: don't allow x-forwarded-host header#2162
Merged
Merged
Conversation
It's a security issue, x-forwarded-host can be retreived from ctx.host when app.config.proxy is true, and be injected to cookie domain.
fengmk2
reviewed
Mar 5, 2018
| assert(req.host === ''); | ||
| }); | ||
|
|
||
| it('should return host from X-Forwarded-Host header', function* () { |
fengmk2
approved these changes
Mar 5, 2018
popomore
commented
Mar 5, 2018
| mm(req.header, 'x-forwarded-host', 'foo.com'); | ||
| mm(req.header, 'host', 'bar.com'); | ||
| assert(typeof req.host === 'string'); | ||
| assert(req.host === 'foo.com'); |
dead-horse
approved these changes
Mar 5, 2018
Member
|
需要 pick 到 master 吧？ |
Member
Author
|
恩，我 pick 一下 |
popomore
added a commit
that referenced
this pull request
Mar 5, 2018
It's a security issue, x-forwarded-host can be retreived from ctx.host when app.config.proxy is true, and be injected to cookie domain.
popomore
added a commit
that referenced
this pull request
Mar 5, 2018
It's a security issue, x-forwarded-host can be retreived from ctx.host when app.config.proxy is true, and be injected to cookie domain. PICK FROM #2162
popomore
added a commit
that referenced
this pull request
Mar 5, 2018
It's a security issue, x-forwarded-host can be retreived from ctx.host when app.config.proxy is true, and be injected to cookie domain. PICK FROM #2162
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
It's a security issue, x-forwarded-host can be retreived
from ctx.host when app.config.proxy is true, and be injected
to cookie domain.