Conversation
307897b to
dd0ae81
Compare
popomore
approved these changes
Sep 11, 2018
Member
Author
|
等下 #2972 ？ |
Codecov Report
@@ Coverage Diff @@
## master #2989 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 29 29
Lines 830 830
=======================================
Hits 828 828
Misses 2 2Continue to review full report at Codecov.
|
Closed
|
Just a notice and feel curoius：What about making 'configDidLoad' async？All the other methods are async. |
Member
Author
|
@Maledong redirect #2520 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change