Thanks to visit codestin.com
Credit goes to github.com

Skip to content

doc (loader.md): Add missing English translations#2996

Merged
killagu merged 1 commit into
masterfrom
unknown repository
Sep 13, 2018
Merged

doc (loader.md): Add missing English translations#2996
killagu merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Sep 12, 2018

Copy link
Copy Markdown
  1. Add missing English translations about the explainations of start
    process in details.
  2. Format some words in a beautiful style.
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@codecov

codecov Bot commented Sep 12, 2018

Copy link
Copy Markdown

Codecov Report

Merging #2996 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2996   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          29       29           
  Lines         830      830           
=======================================
  Hits          828      828           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5bf3d...a9b10ea. Read the comment docs.

@ghost

ghost commented Sep 12, 2018

Copy link
Copy Markdown
Author

Ref:#2972

@killagu killagu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu

killagu commented Sep 12, 2018

Copy link
Copy Markdown
Contributor

If you are free, can you translate the lifecyle.puml too?

@killagu

killagu commented Sep 13, 2018

Copy link
Copy Markdown
Contributor

lifecycle

Comment thread docs/assets/lifecycle.puml
Comment thread docs/source/en/advanced/loader.md Outdated
1) Add missing English translations about the explainations of start
process in details.
2) Format some words in a beautiful style.
@killagu killagu merged commit 4faf68f into eggjs:master Sep 13, 2018
popomore pushed a commit that referenced this pull request Sep 13, 2018
doc (loader.md): Add missing English translations (#2996)

1) Add missing English translations about the explainations of start
process in details.
2) Format some words in a beautiful style.
@ghost

ghost commented Sep 17, 2018

Copy link
Copy Markdown
Author

Thanks you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant