Use caller's workflow name in default footer#546
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (64)
🚧 Files skipped from review as they are similar to previous changes (45)
📝 WalkthroughWalkthroughThis pull request updates safe-output message templates in multiple .github/workflows/*.lock.yml and fragment files, replacing literal Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| --- | ||
| safe-outputs: | ||
| messages: | ||
| footer: "${{ inputs.messages-footer || format('---\n[What is this?](https://ela.st/github-ai-tools) | [From workflow: {0}]({{run_url}})" |
Contributor
There was a problem hiding this comment.
[LOW] Footer expression is left unterminated
This string never closes the format(...) call or the $\{\{ ... }} expression, so when this no-feedback fragment is used the footer value will contain an incomplete expression instead of a rendered workflow name.
Suggested change
| footer: "${{ inputs.messages-footer || format('---\n[What is this?](https://ela.st/github-ai-tools) | [From workflow: {0}]({{run_url}})" | |
| footer: "$\{\{ inputs.messages-footer || format('---\n[What is this?](https://ela.st/github-ai-tools) | [From workflow: {0}](\{\{run_url}})', github.workflow) }}" |
Replace {workflow_name} (hardcoded reusable workflow name) with
github.workflow via format(), which resolves to the caller's workflow
name when the reusable workflow is invoked via workflow_call.
Co-authored-by: Copilot <[email protected]>
be2ab82 to
7d8533d
Compare
Replace {workflow_name} (hardcoded reusable workflow name) with
github.workflow via format(), which resolves to the caller's workflow
name when the reusable workflow is invoked via workflow_call.
Co-authored-by: Copilot <[email protected]>
7d8533d to
662338c
Compare
…ragment Co-authored-by: Copilot <[email protected]>
The no-feedback footer variant is more appropriate for update-pr-body, which auto-generates PR body content — asking for reaction feedback there doesn't make sense. Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates default safe-output footers to display the caller workflow name via
github.workflowinstead of the reusable-workflow placeholder ({workflow_name}).Before
After
Details
format(..., github.workflow)in footer defaults so comments/reviews show the caller workflow name.inputs.messages-footeroverride behavior..lock.ymlworkflows so compiledGH_AW_SAFE_OUTPUT_MESSAGESinclude the updated footer expression..github/workflows/gh-aw-fragments/messages-footer-no-feedback.mdand imports it in.github/workflows/gh-aw-update-pr-body.md.gh-aw-update-pr-bodycompiled workflow so itsGH_AW_SAFE_OUTPUT_MESSAGESincludes a default footer without the feedback line.Scope
.github/workflows/gh-aw-fragments/messages-footer.md.gh-aw-update-pr-body..lock.ymlfiles.Test plan
format('... ', github.workflow)inGH_AW_SAFE_OUTPUT_MESSAGESWhat is this? | From workflow: Trigger Update PR Body