fix: setup middleware without client argument for starlette #1952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basepi
previously approved these changes
Jan 16, 2024
|
Looks great! Thanks for adding a test, too! |
|
@elasticmachine, run elasticsearch-ci/docs |
|
sigh apparently this is hitting #1916 for python 3.12. 3.12.2 can't come fast enough. I'm going to exclude the starlette tests from 3.12 until then. |
basepi
approved these changes
Jan 18, 2024
|
@elasticmachine, run elasticsearch-ci/docs |
trentm
approved these changes
Jan 22, 2024
xrmx
pushed a commit
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Fix TypeError when using the starlette middleware without explicitly providing a client
Related issues
Closes #1951