@xrmx , I might need your help with this approach:

PyPI does not allow for a filename to be reused, even once a project has been deleted and recreated.

Then, a second run failed:

https://github.com/elastic/apm-agent-python/actions/runs/8229823579/job/22501787751

What do you suggest?

@v1v can we postfix a +$GITHASH to the release version? See https://peps.python.org/pep-0440/#adding-local-version-identifiers, the paragraph before last.

can we postfix a +$GITHASH to the release version? See https://peps.python.org/pep-0440/#adding-local-version-identifiers, the paragraph before last.

Nice, but I have no clue how to do it; I can try to figure out but if you know how to, would you mind contributing to this PR? 🙏

can we postfix a +$GITHASH to the release version? See https://peps.python.org/pep-0440/#adding-local-version-identifiers, the paragraph before last.

Nice, but I have no clue how to do it; I can try to figure out but if you know how to, would you mind contributing to this PR? 🙏

Sure, will take a look later today

@v1v What do you think about somethings like this

diff --git a/setup.py b/setup.py
index 23ebec33..235bf4d8 100644
--- a/setup.py
+++ b/setup.py
@@ -100,7 +100,11 @@ def get_version():
     for line in version_file:
         if line.startswith("__version__"):
             version_tuple = ast.literal_eval(line.split(" = ")[1])
-            return ".".join(map(str, version_tuple))
+            version_str = ".".join(map(str, version_tuple))
+            local_version = os.getenv("ELASTIC_CI_LOCAL_VERSION")
+            if local_version:
+                return f"{version_str}+{local_version}"
+            return version_str
     return "unknown"

and then exposing to the packages workflow an ELASTIC_CI_LOCAL_VERSION environment variable with the value of ${{ github.run_id }}?

@xrmx, quick question:

+            local_version = os.getenv("ELASTIC_CI_LOCAL_VERSION")
+            if local_version:

if ELASTIC_CI_LOCAL_VERSION='' will it go through the if local_version condition?

Rationale:

I want to use a top-level environment variable, with something like:

# .github/workflows/release.yml
...

env:
  ELASTIC_CI_LOCAL_VERSION: ${{ startsWith(github.ref, 'refs/tags') && '' ||  github.run_id }}
jobs:
  ...

Then ELASTIC_CI_LOCAL_VERSION='' if a tag release, otherwise ELASTIC_CI_LOCAL_VERSION=${{ github.run_id }}

I need to find how to use the ternary in GitHub actions

Empty string is fine, code checks for a truthy value and empty string is not. Unless you are sending the single quotes

no single quotes, but empty instead, single quotes will be empty in this particular case, I think that's the way to set empty env variables