Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

radupotop
Copy link
Contributor

What does this pull request do?

Make ConfigurationError messages more descriptive on init. This is especially useful where ENV variables are not set.

Turns this error message:

ERROR      {/usr/local/lib/python3.10/site-packages/elasticapm/base.py}  is not a float

into this:

ERROR      {/usr/local/lib/python3.10/site-packages/elasticapm/base.py} TRANSACTION_SAMPLE_RATE= is not a float

Copy link

cla-checker-service bot commented Oct 3, 2024

💚 CLA has been signed

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Oct 3, 2024
@radupotop
Copy link
Contributor Author

Signed CLA

@xrmx
Copy link
Member

xrmx commented Oct 10, 2024

@radupotop thanks for the PR, please run black on it and I'll review it

Copy link
Member

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks like a nice improvement

@xrmx xrmx enabled auto-merge (squash) December 24, 2024 13:59
@xrmx
Copy link
Member

xrmx commented Dec 24, 2024

run docs-build

@xrmx xrmx merged commit 778797b into elastic:main Dec 24, 2024
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python community Issues opened by the community triage Issues awaiting triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants