[Heartbeat] Fix packaging#20566
Merged
Merged
Conversation
There were a few issues with the package target for x-pack/heartbeat.
Member
Author
|
/package |
Member
Author
|
/package |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Member
Author
|
The packaging build passed, but I forgot a Makefile in x-pack/heartbeat so lint failed. I pushed an update so I think it should be good now. |
Member
Author
|
Looks better now. In a follow up I will add x-pack/heartbeat to the Jenkinfile so that it built and tested along with everything else. |
Member
v1v
added a commit
to v1v/beats
that referenced
this pull request
Aug 12, 2020
…ne-2.0 * upstream/master: (39 commits) [ITs] Revert healthcheck for elasticsearchssl service to the previous behaviour (elastic#20558) [Heartbeat] Fix packaging (elastic#20566) [Heartbeat] Add Magefile to X-Pack (elastic#20549) [Packetbeat] Add "network" to event.category (elastic#20392) fix typo in docs (elastic#20541) Add service resource in k8s cluster role (elastic#20546) Update Golang version to 1.14.7 (elastic#20508) Add missing inputs to filebeat spec (elastic#20388) add warning log in aws and googlecloud module for API cost (elastic#20523) Fix fortinet.firewall.mem value to be interpreted as integer (elastic#19335) [CI] add more resilience (elastic#20505) [JJBB] fix credentials with a service account for golang-crossbuild (elastic#20537) [ITs] change healthcheck for elasticsearch (elastic#20514) [JJBB] fix credentials with a service account (elastic#20535) chore(ci): use build step for checking if is PR (elastic#20536) [CI] runbld project name (elastic#20466) Add panw.panos.endreason field (elastic#18705) [Filebeat] Fix PANW field spelling "veredict" to "verdict" (elastic#18808) Fix typo in netflow module docs (elastic#18992) Modified auditd ingest pipeline to handle node=hostname (elastic#19659) ...
andrewvc
pushed a commit
to andrewvc/beats
that referenced
this pull request
Aug 17, 2020
* Heartbeat packaging fixes There were a few issues with the package target for x-pack/heartbeat. * There are no integTests setup in x-pack/heartbeat * Add make files
Contributor
|
backport here #20638 |
andrewvc
added a commit
that referenced
this pull request
Aug 18, 2020
… to X-Pack (#20638) Cherry-pick of PR #20549, #20566, and #20242 to 7.x branch. Original message: There were a few issues with the package target for x-pack/heartbeat. Update root Makefile to build packages for x-pack/heartbeat. Update packaging CI job. Magefile fixes (mostly with where the packaging spec was looking for files). This also restructures the main magefile to share code with the x-pack. This fixes the broken agent build which is trying to run mage build in the x-pack heartbeat folder.
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* Heartbeat packaging fixes There were a few issues with the package target for x-pack/heartbeat. * There are no integTests setup in x-pack/heartbeat * Add make files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There were a few issues with the package target for x-pack/heartbeat.
Why is it important?
This should allow builds and packaging from x-pack/heartbeat to work as expected.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
This was a fast fix so please try it out yourself and examine the package contents.