Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[filebeat][websocket] - Added runtime URL modification support based on state and cursor values #39997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 25, 2024
Merged

[filebeat][websocket] - Added runtime URL modification support based on state and cursor values #39997

merged 11 commits into from
Jun 25, 2024

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Jun 24, 2024 •
edited
Loading

Type of change

  • Enhancement

Proposed commit message

Till now it was not possible to modify the Websocket URL dynamically via the CEL program as the Websocket logic exists
outside the scope of the CEL engine instance. To make this action possible a new instance of the CEL engine was added as a one time execution process to prime the URL before the main CEL program executes. This new CEL instance shares the same state hence its possible to modify and use cursor and state values and in turn modify the URL based off of these values.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ShourieG ShourieG requested review from a team as code owners June 24, 2024 10:09
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 24, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@ShourieG ShourieG requested a review from efd6 June 24, 2024 10:12
ShourieG
ShourieG commented Jun 24, 2024
View reviewed changes
@ShourieG ShourieG added enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team labels Jun 24, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 24, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert requested review from VihasMakwana and removed request for fearful-symmetry June 24, 2024 12:06
@pierrehilbert
Copy link
Collaborator

Hey @ShourieG
I added the necessary label to get your PR reviewed by our team.
Could you please make the linter happy by excluding those lines from the linter check?
As this is not real credential leak, we should make it aware of it.

@ShourieG ShourieG added 8.15-candidate Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jun 24, 2024
@ShourieG
Copy link
Contributor Author

ShourieG commented Jun 24, 2024 •
edited
Loading

Hey @ShourieG I added the necessary label to get your PR reviewed by our team. Could you please make the linter happy by excluding those lines from the linter check? As this is not real credential leak, we should make it aware of it.

Hey @pierrehilbert, I think your team got tagged due to an unintended update to the filebeat.yml file which I have reverted now.
Fixed the linter btw :)

@pierrehilbert
Copy link
Collaborator

run docs-build

belimawr
belimawr reviewed Jun 24, 2024
View reviewed changes
efd6
efd6 reviewed Jun 24, 2024
View reviewed changes
efd6
efd6 reviewed Jun 24, 2024
View reviewed changes
@ShourieG
Copy link
Contributor Author

@efd6, I've addressed all the PR changes and removed the negative syntax tests. @belimawr, your concerns got addressed as the conditions were removed with the latest updates.

@ShourieG ShourieG merged commit 45825bb into elastic:main Jun 25, 2024
@ShourieG ShourieG deleted the enhancement/websocket branch June 25, 2024 06:20
@kcreddy kcreddy mentioned this pull request Jun 25, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belimawr belimawr belimawr left review comments

@efd6 efd6 efd6 approved these changes

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana

Assignees

@ShourieG ShourieG

Labels
8.15-candidate enhancement Filebeat Filebeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[filebeat][websocket] - Add support for passing cursor value as query parameter in Websocket URL
5 participants
@ShourieG @elasticmachine @pierrehilbert @belimawr @efd6