Thanks to visit codestin.com
Credit goes to github.com

Skip to content

x-pack/filebeat/input/http_endpoint: remove raw message retention#41498

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:no-roar-message
Nov 4, 2024
Merged

x-pack/filebeat/input/http_endpoint: remove raw message retention#41498
efd6 merged 1 commit into
elastic:mainfrom
efd6:no-roar-message

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Oct 31, 2024

Proposed commit message

We were doing work to maintain the original request data for each of the events, but this data was never used. So weaken the promise and remove the code that was doing that work.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team labels Oct 31, 2024
@efd6 efd6 self-assigned this Oct 31, 2024
@botelastic botelastic Bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 31, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Oct 31, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @efd6? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Oct 31, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify Bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 31, 2024
We were doing work to maintain the original request data for each of the
events, but this data was never used. So weaken the promise and remove
the code that was doing that work.
@efd6 efd6 marked this pull request as ready for review November 1, 2024 03:27
@efd6 efd6 requested a review from a team as a code owner November 1, 2024 03:27
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 requested a review from andrewkroh November 1, 2024 03:27
@efd6 efd6 merged commit aa2241d into elastic:main Nov 4, 2024
mergify Bot pushed a commit that referenced this pull request Nov 4, 2024
…1498)

We were doing work to maintain the original request data for each of the
events, but this data was never used. So weaken the promise and remove
the code that was doing that work.

(cherry picked from commit aa2241d)
efd6 added a commit that referenced this pull request Nov 28, 2024
…1498) (#41517)

We were doing work to maintain the original request data for each of the
events, but this data was never used. So weaken the promise and remove
the code that was doing that work.

(cherry picked from commit aa2241d)

Co-authored-by: Dan Kortschak <[email protected]>
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants