-
Notifications
You must be signed in to change notification settings - Fork 601
CLI next gen - timeline templates, value lists, and more #5042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CLI next gen - timeline templates, value lists, and more #5042
Conversation
…d elastic checks by default
timeline resolve handling corrected and fixed for export value list, index creation fixed value list delete and exception list deltes corrected error handling for value list imports improved
…unction-in-kbwrap.py' into main-codex
Thanks for the PR @frederikb96! Could you separate out some of the features so that we could evaluate them individually? There are some really good ideas here, but it would work better for us to not have to evaluate all of them in one PR. This is especially true for the Kibana API additions (in the Kibana lib), as it would require changes to our intended scope for this library. Those are much larger changes compared to adding |
Hi, thanks for the reply and the information. I won't have access to my workstation for the next weeks but I will look into it afterwards 🙂 |
Hi there,
I apologize for this big monolithic PR. Since we needed many new functionalities fast to get our automation pipelines running for many customers, we decided to continue implementing this in our fork. Now we have a good set of features and fixes that we would like to contribute back.
I hope that is also somehow beneficial for you and the main repo. At least a lot of time and resources were spent implementing all those new features. In the best case, you can benefit from the changes, and we can benefit from you continuing to maintain it.
We can also arrange a meeting to discuss the changes if you like :)
Features and Fixes
Insights into some files that changed a lot:
Testing and Known Issues:
I went through the whole diff again and checked each file and line once more, and at least I think that I could still explain the purpose of each change if you need help understanding something.
Contributor checklist