Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Mar 19, 2019

Relates to #22679

@ywelsch ywelsch added >docs General docs changes :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure v7.0.0 v8.0.0 v7.2.0 labels Mar 19, 2019
@ywelsch ywelsch requested a review from henningandersen March 19, 2019 18:18
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one addition (either in this or separate PR): I think we should also fix the deprecation logging in AzureDiscoveryPlugin

        deprecationLogger.deprecated("azure classic discovery plugin is deprecated. Use azure arm discovery plugin instead");

@ywelsch ywelsch merged commit 6b03b13 into elastic:master Mar 20, 2019
ywelsch added a commit that referenced this pull request Mar 20, 2019
ywelsch added a commit that referenced this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure >docs General docs changes v7.0.0-rc1 v7.2.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants