Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Symfony HTTP client adapter and remove Accept-Encoding header (gzip) for Symfony #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 8, 2022

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Aug 3, 2022

This PR fixes #1241 removing the Accept-Encoding: gzip header when using the Symfony HTTP client with Elastic Cloud. This is needed due to the Symfony behaviour reported here.

Morever, this PR adds the support of Symfony HTTP client using HttplugClient and Psr18Client adapters.

@ezimuel ezimuel changed the title Remove the gzip Accept-Encoding header for Symfony HTTP client WIP: Remove the gzip Accept-Encoding header for Symfony HTTP client Aug 3, 2022
@ezimuel ezimuel changed the title WIP: Remove the gzip Accept-Encoding header for Symfony HTTP client Add Symfony HTTP client adapter and remove Accept-Encoding header (gzip) for Symfony Aug 4, 2022
@ezimuel ezimuel added this to the 8.4 milestone Aug 4, 2022
@ezimuel ezimuel requested a review from sethmlarson August 4, 2022 15:16
Copy link

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ezimuel ezimuel merged commit 161682c into 8.4 Aug 8, 2022
ezimuel added a commit that referenced this pull request Aug 9, 2022
…ip) for Symfony (#1243)

* Remove the gzip Accept-Encoding header for Symfony HTTP client

* Add the support of symfony http-client v5

* Added Symfony options adapter + use Guzzle as default HTTP client

* Reverted default HTTP client + fixed setOptions
@ezimuel ezimuel deleted the fix/symfony-elastic-cloud branch August 9, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants