Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Theme] Remove duplicate Borealis JSON export files #9066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Theme] Remove duplicate Borealis JSON export files #9066

wants to merge 2 commits into from

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Sep 30, 2025 •
edited
Loading

Summary

This PR removes the JSON export files for Borealis in eui. These were initially added in eui when the Borealis theme was introduced due to issues of loading the files in Kibana from the dedicated theme package.
The issue has been resolved and Kibana already imports the files from eui-theme-borealis instead.

Removed files:

  • packages/eui/src/themes/json/eui_theme_borealis_light.json
  • packages/eui/src/themes/json/eui_theme_borealis_light.json.d.ts
  • packages/eui/src/themes/json/eui_theme_borealis_dark.json
  • packages/eui/src/themes/json/eui_theme_borealis_dark.json.d.ts

Additionally the PR updates the build script that copies static files to the dist folder to remove the obsolete files.

Why are we making this change?

🧰 Maintainability: Removing duplicate and obsolete files and reducing the confusion and risk of errors when updating tokens.

Screenshots #

Impact to users

⚠️ Breaking change (if the files were used).

🟢 Kibana was already updated ahead of time (code).

QA

  • verify the eui packages build correct (yarn build-pack) and that the removed files are not included in the build package
  • verify the files are present in eui-theme-borealis

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@mgadewoll mgadewoll self-assigned this Sep 30, 2025
@mgadewoll mgadewoll added the breaking change PRs with breaking changes. (Don't delete - used for automation) label Sep 30, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2025 •
edited by mgadewoll
Loading

This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:

  • If this PR contains prop/API changes:
    • Search through Kibana for <EuiComponent usages (example search)
    • In the PR description or in a PR comment, include a count or list with the number of component usages in Kibana that will need to be updated (if that amount is "none", include that information as well)
  • If this PR contains CSS changes:
    • Search through Kibana for the changed EUI selectors, e.g. .euiComponent (example search)
    • In the PR description or in a PR comment, include a count or list with the number of custom CSS overrides in Kibana that will need to be updated (if that amount is "none", include that information as well)
  • 🔍 Tip: When searching through Kibana, consider excluding **/target, **/*.snap, **/*.storyshot files to reduce noise and only look at source code usages
  • ⚠️ For extremely risky changes, the EUI team should potentially consider the following precautions:
    • Using a pre-release release candidate to test Kibana CI ahead of time
    • Using kibana-a-la-carte for manual QA, and to give other Kibana teams a staging server to quickly test against

@mgadewoll
chore: remove obsolete duplicated borealis json export files
46a1696 
- the duplicated files where a temporary workaround, they are now imported from eui-theme-borealis in Kibana
@mgadewoll
chore: add changelog
40eeea9
@mgadewoll mgadewoll force-pushed the theme/remove-duplicate-borealis-json-export-files branch from 54f43d6 to 40eeea9 Compare September 30, 2025 12:18
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mgadewoll

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mgadewoll

@mgadewoll mgadewoll marked this pull request as ready for review September 30, 2025 13:28
@mgadewoll mgadewoll requested a review from a team as a code owner September 30, 2025 13:28
acstll
acstll approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 This was pretty much needed, thank you! Checked the packed tarball and double-checked in eui-theme-borealis, everything working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acstll acstll acstll approved these changes

Assignees

@mgadewoll mgadewoll

Labels

breaking change PRs with breaking changes. (Don't delete - used for automation)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgadewoll @elasticmachine @acstll