Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Alphayeeeet
Copy link
Contributor

@Alphayeeeet Alphayeeeet commented Jul 8, 2024

Proposed commit message

Remove event.original removal processors

  • 1Password
  • ActiveMQ
  • Akamai
  • Amazon Security Lake
  • Apache
  • Apache Tomcat
  • Arista
  • Atlassian Bitbucket
  • Atlassian Confluence
  • Atlassian Jira
  • Auditd
  • Auditd_Manager
  • Auth0

AWS and Azure will be part of a future PR

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Review #10072 for additional info

@Alphayeeeet Alphayeeeet requested a review from a team as a code owner July 8, 2024 19:46
@Alphayeeeet Alphayeeeet marked this pull request as draft July 8, 2024 19:47
@Alphayeeeet
Copy link
Contributor Author

Apache pre-release is used to bump version up together with #10416

@Alphayeeeet Alphayeeeet marked this pull request as ready for review July 8, 2024 20:09
@Alphayeeeet Alphayeeeet requested review from a team as code owners July 8, 2024 20:09
@Alphayeeeet
Copy link
Contributor Author

Could someone run CI for the tests? Thank you in advance. I will merge back from main and bump up version in manifests after initial review from anyone.

@ishleenk17
Copy link
Member

/test

@Alphayeeeet
Copy link
Contributor Author

@ishleenk17 Thanks for running tests. I have one question. Do tests fail, when i did not include the new version/pre-release in the maifests.yml. According to doc, on pre-releases this should not be necessary as multiple PR'S can result in the same version.

Do I need to populate pre-releases (see Apache integration) in the manifests.yml?

Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alphayeeeet Yes the same change would be required in the manifest else the CI won't be happy

@Alphayeeeet
Copy link
Contributor Author

Alphayeeeet commented Jul 9, 2024

@ishleenk17 I added the manifest versions. Can you please run CI again?

PS: I might have tagged the wrong people as you have the same avatar @aliabbas-elastic

@ali786XI
Copy link
Contributor

ali786XI commented Jul 9, 2024

/test

@elasticmachine
Copy link

elasticmachine commented Jul 9, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@Alphayeeeet
Copy link
Contributor Author

Unfortunately I have no access to Sonarqube and cannot review the failed objective on code coverage.

@Alphayeeeet
Copy link
Contributor Author

Please run CI again

@Alphayeeeet Alphayeeeet requested a review from efd6 July 16, 2024 08:52
@andrewkroh andrewkroh added Integration:activemq ActiveMQ Integration:akamai Akamai (Community supported) Integration:apache Apache HTTP Server labels Jul 19, 2024
@ali786XI
Copy link
Contributor

/test

@Alphayeeeet
Copy link
Contributor Author

@aliabbas-elastic @andrewkroh @efd6 Is the CI failing test some kind of bug in the CI or what is wrong with the integration? As I have no idea what the problem is to be honest.

@efd6
Copy link
Contributor

efd6 commented Jul 29, 2024

There is an issue with starting a service required for the system test.

Error: error running package system tests: could not complete test run: could not setup service: service is unhealthy: container (ID: ****) exited with code 127

I've tried running this locally and it works. The container does take a while to start up, so maybe in CI it is just taking a little too long? @elastic/sec-linux-platform do you have any ideas what might be going on here?

@andrewkroh
Copy link
Member

/test

@andrewkroh andrewkroh disabled auto-merge August 9, 2024 22:17
@andrewkroh
Copy link
Member

I have asked the the ecosystem team on Slack about the failure here. Specifically,

  • is the failure caused by a resource constraint problem associated with auditd running a separate Elastic Agent container,
  • and why isn't the log file from the container include in the buildkite artifacts list.

I think we can bypass the CI failure if needed, but we'll give that team a little time to investigate. I also saw another auditd_manager PR that is failing (might be the same cause).

@andrewkroh
Copy link
Member

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @Alphayeeeet

Copy link

@andrewkroh andrewkroh merged commit 989c440 into elastic:main Aug 13, 2024
5 checks passed
@elasticmachine
Copy link

Package 1password - 1.30.0 containing this change is available at https://epr.elastic.co/search?package=1password

@elasticmachine
Copy link

Package activemq - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=activemq

@elasticmachine
Copy link

Package akamai - 2.25.0 containing this change is available at https://epr.elastic.co/search?package=akamai

@elasticmachine
Copy link

Package amazon_security_lake - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=amazon_security_lake

@elasticmachine
Copy link

Package apache - 1.24.0 containing this change is available at https://epr.elastic.co/search?package=apache

@elasticmachine
Copy link

Package apache_tomcat - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=apache_tomcat

@elasticmachine
Copy link

Package arista_ngfw - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=arista_ngfw

@elasticmachine
Copy link

Package atlassian_bitbucket - 2.2.0 containing this change is available at https://epr.elastic.co/search?package=atlassian_bitbucket

@elasticmachine
Copy link

Package atlassian_confluence - 1.26.0 containing this change is available at https://epr.elastic.co/search?package=atlassian_confluence

@elasticmachine
Copy link

Package atlassian_jira - 1.27.0 containing this change is available at https://epr.elastic.co/search?package=atlassian_jira

@elasticmachine
Copy link

Package auditd - 3.20.0 containing this change is available at https://epr.elastic.co/search?package=auditd

@elasticmachine
Copy link

Package auditd_manager - 1.17.0 containing this change is available at https://epr.elastic.co/search?package=auditd_manager

@elasticmachine
Copy link

Package auth0 - 1.18.0 containing this change is available at https://epr.elastic.co/search?package=auth0

@Alphayeeeet Alphayeeeet deleted the refactor-remove-event-original-removal branch August 27, 2024 14:29
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…uth0) (elastic#10417)

Delete the remove event.original processors from the pipelines because as of 8.11 the Fleet final pipeline now does this automatically when the `preserve_original_event` tag is not present in the event.

This bumps the minimum version to 8.11.0 because it depends on the Fleet final pipeline changes.

auditd_manager was bumped to require 8.12.0 because the system tests were failing under 8.11.0.

Relates elastic#10072
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…uth0) (elastic#10417)

Delete the remove event.original processors from the pipelines because as of 8.11 the Fleet final pipeline now does this automatically when the `preserve_original_event` tag is not present in the event.

This bumps the minimum version to 8.11.0 because it depends on the Fleet final pipeline changes.

auditd_manager was bumped to require 8.12.0 because the system tests were failing under 8.11.0.

Relates elastic#10072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:activemq ActiveMQ Integration:akamai Akamai (Community supported) Integration:amazon_security_lake Amazon Security Lake Integration:apache_tomcat Apache Tomcat Integration:apache Apache HTTP Server Integration:arista_ngfw Arista NG Firewall (Community supported) Integration:atlassian_bitbucket Atlassian Bitbucket (Community supported) Integration:atlassian_confluence Atlassian Confluence (Community supported) Integration:atlassian_jira Atlassian Jira (Community supported) Integration:auditd_manager Auditd Manager Integration:auditd Auditd Logs Integration:auth0 Auth0 Integration:1password 1Password (Partner supported) Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants