Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

qcorporation
Copy link
Contributor

@qcorporation qcorporation commented Feb 26, 2025

Parent Ticket:
#11810

Proposed commit message

  • Updated the documentation based upon agreed upon language to highlight that the integration now supports Agentless deployment
    screencapture-m365-defender-testing-kb-eastus2-staging-azure-foundit-no-app-integrations-detail-google-scc-1-8-0-overview-2025-02-26-14_29_48

  • Upgraded the format_version to latest, 3.2.3

  • Updated Kibana version constraints to ^8.18 || ^9.0.0

  • Update the default.yml datastream to follow package-spec 3.2.3

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Testing

  1. Followed the onboarding to setup a new service account within google with the proper permissions and downloaded the key-json file
  2. Enabled Security Command Center API through the activation link
  3. Setup the integration to fetch assets through the api
  4. Validated that data flowed to ES
  5. Validated no noticeable errors were found within the agent diagnostics
  6. Validated dashboards were working fine

@qcorporation qcorporation added enhancement New feature or request Team:Service-Integrations Label for the Observability Service Integrations team Integration:google_scc Google Security Command Center Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Feb 26, 2025
@qcorporation qcorporation requested review from a team February 26, 2025 19:38
@qcorporation qcorporation self-assigned this Feb 26, 2025
conditions:
kibana:
version: "^8.13.0"
version: "^8.18.0 || ^9.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge of this change be held until the release date of 8.18?

Copy link
Contributor Author

@qcorporation qcorporation Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efd6 I don't think so. Because of this restrictions only 8.18 stacks and 9.0 stacks will see this upgrade. So this aligns with releasing it on 8.18.
The only downside would be that changes to this integration for bug fixes will be more difficult for stacks < 8.18

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only downside would be that changes to this integration for bug fixes will be more difficult for stacks

Historically, this has been a big downside.

@qcorporation qcorporation marked this pull request as ready for review February 26, 2025 21:16
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@qcorporation qcorporation requested review from efd6 and a team March 3, 2025 19:40
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, otherwise LGTM

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @qcorporation

Copy link

@qcorporation qcorporation merged commit 984ba31 into main Mar 4, 2025
7 checks passed
@qcorporation qcorporation deleted the 11810-google_scc branch March 4, 2025 18:59
@elastic-vault-github-plugin-prod

Package google_scc - 1.8.1 containing this change is available at https://epr.elastic.co/package/google_scc/1.8.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:google_scc Google Security Command Center Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Service-Integrations Label for the Observability Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants