Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update ssl option descriptions in manifest.yml files. Cleanup and missed packaged owned by Security Service Integrations #12997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2025
Merged

Update ssl option descriptions in manifest.yml files. Cleanup and missed packaged owned by Security Service Integrations #12997

merged 3 commits into from
Mar 10, 2025

Conversation

StacieClark-Elastic
Copy link
Member

Proposed commit message

Updates description field on ssl nodes in package level manifest.yml file to include links to online documentation and to be consistent with other integrations. This captures packages that were missed in an earlier PR

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Originally, we updated the descriptions on all the files in integration. This created some issues with so many teams needing to validate the files. This is currently a partial update with files that are owned by security-service-integrations

git diff main | grep description: | grep + | sort -u
results in the update fields for the ssl node description and the changelog.yml

Related issues

@StacieClark-Elastic StacieClark-Elastic added Integration:panw_cortex_xdr Palo Alto Cortex XDR Integration:zscaler_zia Zscaler Internet Access bugfix Pull request that fixes a bug issue Integration:qualys_vmdr Qualys VMDR Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:admin_by_request Integration:beyondinsight_password_safe BeyondInsight and Password Safe labels Mar 6, 2025
@StacieClark-Elastic StacieClark-Elastic self-assigned this Mar 6, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Mar 6, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@StacieClark-Elastic
bugfix/update-ssl-option-descriptions-package-manifest-cleanup-securi…
5b00105 
…ty-service-integration-12994

Added descriptions on SSL nodes in manifest.yml files
@StacieClark-Elastic
bugfix/update-ssl-option-descriptions-package-manifest-cleanup-securi…
efb6818 
…ty-service-integration-12994

added correct PR number to changelopg.yml
@StacieClark-Elastic StacieClark-Elastic force-pushed the bugfix/update-ssl-option-descriptions-package-manifest-cleanup-security-service-integration-12994 branch from a342f16 to efb6818 Compare March 7, 2025 11:03
@StacieClark-Elastic StacieClark-Elastic marked this pull request as ready for review March 7, 2025 11:03
@StacieClark-Elastic StacieClark-Elastic requested a review from a team as a code owner March 7, 2025 11:03
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@StacieClark-Elastic StacieClark-Elastic enabled auto-merge (squash) March 7, 2025 11:46
kcreddy
kcreddy reviewed Mar 7, 2025
View reviewed changes
@StacieClark-Elastic
bugfix/update-ssl-option-descriptions-package-manifest-cleanup-securi…
38fee2d 
…ty-service-integration-12994

Changed a link to point to filebeat. Fixed a typo.
@StacieClark-Elastic StacieClark-Elastic changed the title bugfix/update-ssl-option-descriptions-package-manifest-cleanup-securi… Update ssl option descriptions in manifest.yml files. Cleanup and missed packaged owned by Security Service Integrations Mar 10, 2025
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @StacieClark-Elastic

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

kcreddy
kcreddy approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@StacieClark-Elastic StacieClark-Elastic merged commit c58e312 into elastic:main Mar 10, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package admin_by_request_epm - 0.2.1 containing this change is available at https://epr.elastic.co/package/admin_by_request_epm/0.2.1/

@elastic-vault-github-plugin-prod
Copy link

Package beyondinsight_password_safe - 0.2.1 containing this change is available at https://epr.elastic.co/package/beyondinsight_password_safe/0.2.1/

@elastic-vault-github-plugin-prod
Copy link

Package panw_cortex_xdr - 2.1.2 containing this change is available at https://epr.elastic.co/package/panw_cortex_xdr/2.1.2/

@elastic-vault-github-plugin-prod
Copy link

Package qualys_vmdr - 6.2.2 containing this change is available at https://epr.elastic.co/package/qualys_vmdr/6.2.2/

@elastic-vault-github-plugin-prod
Copy link

Package sailpoint_identity_sc - 0.2.1 containing this change is available at https://epr.elastic.co/package/sailpoint_identity_sc/0.2.1/

@elastic-vault-github-plugin-prod
Copy link

Package zscaler_zia - 3.7.2 containing this change is available at https://epr.elastic.co/package/zscaler_zia/3.7.2/

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
@StacieClark-Elastic @flexitrev
bugfix/update-ssl-option-descriptions-package-manifest-cleanup-securi… (
73181ad 
#12997)

* bugfix/update-ssl-option-descriptions-package-manifest-cleanup-security-service-integration-12994
Added descriptions on SSL nodes in manifest.yml files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@StacieClark-Elastic StacieClark-Elastic

Labels
bugfix Pull request that fixes a bug issue Integration:admin_by_request_epm Admin By Request EPM Integration:beyondinsight_password_safe BeyondInsight and Password Safe Integration:panw_cortex_xdr Palo Alto Cortex XDR Integration:qualys_vmdr Qualys VMDR Integration:sailpoint_identity_sc Sailpoint Identity Security Cloud Integration:zscaler_zia Zscaler Internet Access Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation changes for SSL node for integrations - cleanup- security-service-integrations
4 participants
@StacieClark-Elastic @elasticmachine @kcreddy @andrewkroh