Thanks to visit codestin.com
Credit goes to github.com

Skip to content

sonarqube: Update exclusions paths #14880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

sonarqube: Update exclusions paths #14880

wants to merge 1 commit into from

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Aug 8, 2025 •
edited
Loading

Proposed commit message

Currently almost all PRs that has changes to transform fail
SonarQube checks because transform code is not covered
by any of the tests. Example: #14629 (comment)

Until elastic/elastic-package#2704 is implemented, this
temporary fix ensures SonarQube skips following files where
the coverage is not yet offered by elastic-package tests,
thus avoiding false positives:

./data_stream/*/lifecycle.yml
./data_stream/*/elasticsearch/ilm/*
./elasticsearch/transform/*
./kibana/tags.yml
./kibana/tag/*
./validation.yml

Related issues

@kcreddy kcreddy changed the title sonarqube: Add more exclusions paths temporarily sonarqube: Add more exclusions paths Aug 8, 2025
@kcreddy kcreddy changed the title sonarqube: Add more exclusions paths sonarqube: Update exclusions paths Aug 8, 2025
@kcreddy kcreddy self-assigned this Aug 8, 2025
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

Package google_scc 👍(0) 💚(1) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
asset 1976.28 1449.28 -527 (-26.67%) 💔
audit 3144.65 2645.5 -499.15 (-15.87%) 💔
source 66666.67 35714.29 -30952.38 (-46.43%) 💔

To see the full report comment with /test benchmark fullreport

@kcreddy kcreddy marked this pull request as ready for review August 11, 2025 05:45
@kcreddy kcreddy requested a review from a team as a code owner August 11, 2025 05:45
@kcreddy
Copy link
Contributor Author

kcreddy commented Aug 11, 2025

CI error (failing system tests inside sentinel_one_cloud_funnel package) is unrelated to this change.

@kcreddy kcreddy added Category: Integration quality Category: Quality used for SI planning Team:Ecosystem Packages Ecosystem team [elastic/ecosystem] labels Aug 11, 2025
@elasticmachine
Copy link

Pinging @elastic/ecosystem (Team:Ecosystem)

@kcreddy kcreddy removed the Category: Integration quality Category: Quality used for SI planning label Aug 11, 2025
@kcreddy
Copy link
Contributor Author

kcreddy commented Aug 14, 2025

/test

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @kcreddy

@kcreddy
Copy link
Contributor Author

kcreddy commented Aug 14, 2025 •
edited
Loading

@elastic/ecosystem PTAL. This PR prevents skewing of SonarQube coverage quality due to unchecked files by adding exclusions on them. Example: #14809 (comment).

@jsoriano
Copy link
Member

I would prefer to update coverage reports in elastic-package, at least for the files covered by some test. Doing this in elastic/elastic-package#2831.

@kcreddy
Copy link
Contributor Author

kcreddy commented Aug 19, 2025

Closing in favour of adding coverage: elastic/elastic-package#2831

@kcreddy kcreddy closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kcreddy kcreddy

Labels
Team:Ecosystem Packages Ecosystem team [elastic/ecosystem]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kcreddy @elasticmachine @jsoriano