[iptables] added optional space to process vyos logs #14948
Conversation
6ef3a27 to
648e7a4
Compare
🚀 Benchmarks reportTo see the full report comment with |
| - '%{IPTABLES_ACTION}%{GREEDYDATA}%{IPTABLES}%{SPACE}' | ||
| - '%{IPTABLES_HOSTNAME}%{SPACE}%{UDM_LOGS}%{IPTABLES_IP_PAYLOAD}' | ||
| - '%{GREEDYDATA}\[%{UBIQUITI_LABEL}\]%{IPTABLES}%{SPACE}' | ||
| - '%{GREEDYDATA}\[%{UBIQUITI_LABEL}\](%{SPACE})?%{IPTABLES}%{SPACE}' |
There was a problem hiding this comment.
Why the trailing %{SPACE}? Is that necessary? The pattern is not anchored with $ so IIUC it will effectively ignore trailing space at the end. It's not covered by the test case either.
There was a problem hiding this comment.
Regarding the trailing space at the end of these patterns, I think it's not necessary. I tested it and it made no difference to the expected logs & current test cases. I will remove it from the patterns.
💚 Build Succeeded
History
|
|
|
Package iptables - 1.21.3 containing this change is available at https://epr.elastic.co/package/iptables/1.21.3/ |
Proposed commit message
Checklist
changelog.ymlfile.- [] I have verified that Kibana version constraints are current according to guidelines.- [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practicesHow to test this PR locally
Run and observe the new pipeline test to see expected corrected results.
Related Issues
Closes #10881