Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

MichaelKatsoulis
Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis commented Sep 1, 2021

What does this PR do?

Replaces the default host for proxy data stream in kubernetes package from localhost:10249 to ${env.NODE_NAME}:10249.
The proxy metrics can be fetched from the pod by using the k8s node name and proxy port as it is accessible from inside the pod.
This is a step towards getting rid of hostNetwork:true setting in agent deployment configuration.
elastic/beats#25739

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Screenshots

proxy

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@elasticmachine
Copy link

elasticmachine commented Sep 1, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-01T09:38:49.670+0000

  • Duration: 29 min 25 sec

  • Commit: ea86f2a

Test stats 🧪

Test Results
Failed 0
Passed 113
Skipped 0
Total 113

Trends 🧪

Image of Build Times

Image of Tests

@cfloressuazo
Copy link

cfloressuazo commented Aug 10, 2022

How should I setup by default the kubernetes integration with fleet? It seems like this PR breaks some of the ELK manifests for monitoring kubernetes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants