Spring boot package [Httptrace - data stream] #2978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/integrations (Team:Integrations) |
mtojek
reviewed
Apr 4, 2022
mtojek
suggested changes
Apr 14, 2022
| @@ -0,0 +1 @@ | |||
| {"timestamp":"2022-03-04T16:05:16.022Z","principal":null,"session":null,"request":{"method":"GET","uri":"http://10.0.14.124:8090/actuator/jolokia/read/java.lang:name=PS%20Old%20Gen,type=MemoryPool/Usage,UsageThresholdCount,UsageThresholdSupported,UsageThreshold,UsageThresholdExceeded,PeakUsage,CollectionUsage,CollectionUsageThresholdCount,CollectionUsageThreshold,CollectionUsageThresholdSupported,CollectionUsageThresholdExceeded,Name,Type,Valid?ignoreErrors=true&canonicalNaming=false","headers":{"host":["10.0.14.124:8090"],"accept-encoding":["gzip"],"user-agent":["Elastic-Metricbeat/8.0.0 (linux; amd64; 2ab3a7334016f570e0bfc7e9a577a35a22e02df5; 2022-02-03 18:14:06 +0000 UTC)"]},"remoteAddress":null},"response":{"status":200,"headers":{"Transfer-Encoding":["chunked"],"X-Frame-Options":["DENY"],"Cache-Control":["no-cache"],"X-Content-Type-Options":["nosniff"],"Set-Cookie":["JSESSIONID=290A264B870BB15FF8DDB6B91D098A8D; Path=/; HttpOnly"],"Expires":["Fri, 04 Mar 2022 15:05:16 GMT"],"Pragma":["no-cache"],"X-XSS-Protection":["1; mode=block"],"Date":["Fri, 04 Mar 2022 16:05:16 GMT"],"Content-Type":["text/plain;charset=utf-8"]}},"timeTaken":1} No newline at end of file | |||
There was a problem hiding this comment.
Could you please use a test where fields are not null values? We will be sure that we process values correctly.
There was a problem hiding this comment.
Yeah its updated.
mtojek
suggested changes
Apr 15, 2022
packages/spring_boot/changelog.yml
Outdated
| # newer versions go on top | ||
| - version: "0.1.0" | ||
| changes: | ||
| - description: Initial draft of the package |
There was a problem hiding this comment.
Since you've already merged the skeleton, it would be good to add a separate entry to the changelog for this data stream. Please also bump up the version in manifest.
There was a problem hiding this comment.
Yeah its done
mtojek
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist
changelog.ymlfile.manifest.ymlfile to point to the latest Elastic stack release (e.g.^8.0.0).How to test this PR locally
Note: We have covered dashboards and the visualisations for all data streams of spring boot into separate PR. Also Kibana version will be updated to 8.1.0 in manifest.yml after testing this integration on 8.1.0.