Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Send dataYaml (Rules Activation YAML) to Agent #3241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2022
Merged

Send dataYaml (Rules Activation YAML) to Agent #3241

merged 1 commit into from
May 4, 2022

Conversation

yashtewari
Copy link
Contributor

@yashtewari yashtewari commented May 1, 2022 •
edited
Loading

What does this PR do?

The information in dataYaml var (which is functionally the Rules Activation YAML) is sent to cloudbeat via the Agent policy, where it can be consumed for cloudbeat to know which rules to run.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Within the package directory,

elastic-package build
elastic-package up

Create an Agent policy and view its full contents. Changes made to the dataYaml var will be reflected as data stream input in the Agent policy.

@yashtewari yashtewari added the enhancement New feature or request label May 1, 2022
@yashtewari yashtewari requested a review from a team as a code owner May 1, 2022 07:18
@elasticmachine
Copy link

elasticmachine commented May 1, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-04T08:41:14.748+0000

  • Duration: 16 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 1, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.39
Classes 100.0% (0/0) 💚 3.39
Methods 33.333% (1/3) 👎 -54.93
Lines 100.0% (0/0) 💚 11.098
Conditionals 100.0% (0/0) 💚

eyalkraft
eyalkraft approved these changes May 1, 2022
View reviewed changes
Copy link
Contributor

@eyalkraft eyalkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Please merge only after testing e2e :)

packages/cis_kubernetes_benchmark/changelog.yml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails because you also need to update the versions in the manifest of each integration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eyal!

@yashtewari yashtewari merged commit 549b3ea into elastic:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalkraft eyalkraft eyalkraft approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yashtewari @elasticmachine @eyalkraft