Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add new csp rule templates to the cloud-security-posture integration #3486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 8, 2022
Merged

Add new csp rule templates to the cloud-security-posture integration #3486

merged 3 commits into from
Jun 8, 2022

Conversation

uri-weisman
Copy link
Contributor

@uri-weisman uri-weisman commented Jun 8, 2022 •
edited
Loading

What does this PR do?

Adds new csp rule templates

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@uri-weisman uri-weisman marked this pull request as ready for review June 8, 2022 13:16
@uri-weisman uri-weisman requested a review from a team as a code owner June 8, 2022 13:16
@elasticmachine
Copy link

elasticmachine commented Jun 8, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-08T13:34:31.739+0000

  • Duration: 15 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.343
Classes 100.0% (0/0) 💚 3.343
Methods 33.333% (1/3) 👎 -56.243
Lines 100.0% (0/0) 💚 10.609
Conditionals 100.0% (0/0) 💚

eyalkraft
eyalkraft approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@eyalkraft eyalkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Make sure to promote the new version of the integration (@jeniawhite created a relevant readme)

@uri-weisman uri-weisman merged commit 601a00f into elastic:main Jun 8, 2022
@uri-weisman uri-weisman deleted the add_rule_templates branch June 8, 2022 14:13
@eyalkraft
Copy link
Contributor

eyalkraft commented Jun 8, 2022 •
edited
Loading

Follow up @uri-weisman:
Let's change the required stack version for the package since these new rules will only be supported by cloudbeat 8.4 as you said.
Edit:
Since our constraint is on cloudbeat (and the agent) we need to understand how to reflect that in the integration package as we think the integration package constraint might only refer to Kibana, Which can work with older versions of the Elastic agent too (support matrix):

Elastic Agent is compatible with stack components either on this version or newer versions.

@kfirpeled kfirpeled added the Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalkraft eyalkraft eyalkraft approved these changes

Assignees
No one assigned
Labels
Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uri-weisman @elasticmachine @eyalkraft @kfirpeled