Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[OSQuery] Fix Field Mapping Conflicts #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2022
Merged

[OSQuery] Fix Field Mapping Conflicts #3725

merged 3 commits into from
Aug 1, 2022

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Fix Field conflicts

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner July 17, 2022 13:44
@elasticmachine
Copy link

elasticmachine commented Jul 17, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-28T16:20:05.781+0000

  • Duration: 17 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@james-elastic james-elastic mentioned this pull request Jul 18, 2022
Closed
@efd6
Copy link
Contributor

efd6 commented Jul 19, 2022

/test

aleksmaus
aleksmaus approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@aleksmaus aleksmaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.868
Classes 100.0% (0/0) 💚 2.868
Methods 33.333% (1/3) 👎 -55.917
Lines 100.0% (0/0) 💚 9.399
Conditionals 100.0% (0/0) 💚

@aleksmaus
Copy link
Contributor

@legoguy1000 let me know when you are going to merge this. I will have another update to this integration for our upgrade to osquery 5.4.0 which might conflict with some of the files you touched.

@legoguy1000
Copy link
Contributor Author

legoguy1000 commented Aug 1, 2022 via email

@aleksmaus
Copy link
Contributor

Ahh, ok. I'll merge.

@aleksmaus aleksmaus merged commit d8fdbae into elastic:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aleksmaus aleksmaus aleksmaus approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OSQuery] Non-compliant ECS field mappings causing conflicts
4 participants
@legoguy1000 @elasticmachine @efd6 @aleksmaus