Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove comma from rule id #3912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 8, 2022
Merged

Remove comma from rule id #3912

merged 4 commits into from
Aug 8, 2022

Conversation

amirbenun
Copy link
Contributor

@amirbenun amirbenun commented Aug 1, 2022 •
edited
Loading

Fixes elastic/cloudbeat#227

What does this PR do?

Fix a typo in a CSP rule id

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@amirbenun amirbenun added the bug Something isn't working, use only for issues label Aug 1, 2022
@amirbenun amirbenun requested a review from a team as a code owner August 1, 2022 07:26
@elasticmachine
Copy link

elasticmachine commented Aug 1, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-08T08:46:52.344+0000

  • Duration: 15 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 1, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.863
Classes 100.0% (0/0) 💚 2.863
Methods 25.0% (1/4) 👎 -64.262
Lines 100.0% (0/0) 💚 9.359
Conditionals 100.0% (0/0) 💚

@ofiriro3 ofiriro3 self-requested a review August 1, 2022 08:23
ofiriro3
ofiriro3 suggested changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@ofiriro3 ofiriro3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but we just need to add a new commit to the integration log- packages/cloud_security_posture/changelog.yml

ofiriro3
ofiriro3 suggested changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@ofiriro3 ofiriro3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong log type ⏰

packages/cloud_security_posture/changelog.yml Outdated
- version: "0.0.23"
changes:
- description: Fix rule id typo
type: enhancement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type should be bugfix

ofiriro3
ofiriro3 approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@ofiriro3 ofiriro3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please check my comment.

packages/cloud_security_posture/changelog.yml Outdated
changes:
- description: Fix rule id typo
type: bugfix
link: https://github.com/elastic/cloudbeat/issues/227
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - I see that all other git logs here link the integration PR, and not the GitHub issue.

@amirbenun amirbenun merged commit cbe4d07 into elastic:main Aug 8, 2022
@amirbenun amirbenun deleted the bug-227/ruleid-remove-comma branch August 8, 2022 10:59
@kfirpeled kfirpeled added the Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ofiriro3 ofiriro3 ofiriro3 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working, use only for issues Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Rule id that includes a comma at the end
4 participants
@amirbenun @elasticmachine @ofiriro3 @kfirpeled