Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Spring Boot] Update the field in audit_events data stream dashboard #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 30, 2022
Merged

[Spring Boot] Update the field in audit_events data stream dashboard #3960

merged 4 commits into from
Aug 30, 2022

Conversation

harnish-crest
Copy link
Contributor

@harnish-crest harnish-crest commented Aug 5, 2022 •
edited
Loading

  • Bug

What does this PR do?

This PR is of the Spring Boot integration to update the field name in audit_events data stream dashboard and some nits in fields descriptions. Along with the fixes, it also enhances the integration by following some of the best practices of integration development.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/spring_boot directory.
  • Run the following command to run tests.

elastic-package test

@harnish-crest harnish-crest requested a review from a team as a code owner August 5, 2022 07:11
@elasticmachine
Copy link

elasticmachine commented Aug 5, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-05T10:22:09.720+0000

  • Duration: 19 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 36
Skipped 0
Total 36

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@yug-rajani yug-rajani added bug Something isn't working, use only for issues Integration:spring_boot Spring Boot Team:Service-Integrations Label for the Observability Service Integrations team labels Aug 5, 2022
@yug-rajani
Copy link
Contributor

/test

@elasticmachine
Copy link

elasticmachine commented Aug 5, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.953
Classes 100.0% (2/2) 💚 2.953
Methods 100.0% (27/27) 💚 10.458
Lines 93.289% (139/149) 👍 1.808
Conditionals 100.0% (0/0) 💚

@yug-rajani
Copy link
Contributor

/test

1 similar comment
@yug-rajani
Copy link
Contributor

/test

kush-elastic
kush-elastic approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harnish-crest harnish-crest changed the title [Spring Boot] Update as per best practices [Spring Boot] Update the field in audit_events data stream dashboard Aug 5, 2022
@harnish-crest harnish-crest marked this pull request as draft August 8, 2022 05:53
@harnish-crest harnish-crest marked this pull request as ready for review August 9, 2022 11:21
@harnish-crest harnish-crest requested review from ishleenk17 and removed request for lalit-satapathy August 30, 2022 07:19
@yug-rajani yug-rajani merged commit 413065d into elastic:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishleenk17 ishleenk17 ishleenk17 approved these changes

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@harnish-crest harnish-crest

Labels
bug Something isn't working, use only for issues Integration:spring_boot Spring Boot Team:Service-Integrations Label for the Observability Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harnish-crest @elasticmachine @yug-rajani @kush-elastic @ishleenk17