Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Cloud Security] Add cspm/kspm icons #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 8, 2023
Merged

[Cloud Security] Add cspm/kspm icons #5199

merged 5 commits into from
Feb 8, 2023

Conversation

orouz
Copy link
Contributor

@orouz orouz commented Feb 7, 2023

What does this PR do?

Adds icons for policy templates, so in total we'd have 3 icons including one for the top package.

Related issues

Screenshots

Screenshot 2023-02-07 at 13 06 49
Screenshot 2023-02-07 at 13 06 41

@orouz orouz added enhancement New feature or request Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] labels Feb 7, 2023
orouz
orouz commented Feb 7, 2023
View reviewed changes
packages/cloud_security_posture/changelog.yml Outdated
@@ -1,9 +1,9 @@
# newer versions go on top
- version: "1.2.10-next"
- version: "1.2.11"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kfirpeled

not sure what should this be?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the next is a placeholder for the next release, so we can pack mutilple PRs into a single release

@elasticmachine
Copy link

elasticmachine commented Feb 7, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-08T10:50:55.409+0000

  • Duration: 15 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@orouz
Copy link
Contributor Author

orouz commented Feb 7, 2023

CI is failing with this for all 3 icons:

relative path is invalid, target doesn't exist or it exceeds the file size limit
  • i'm using the latest release and locally check/lint both pass, as does build
  • those files do exists
  • one of them is a bit big, but don't think they pass the limit (not sure what it is)

kfirpeled
kfirpeled reviewed Feb 7, 2023
View reviewed changes
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (1/4) 👎 -35.759
Lines 100.0% (0/0) 💚 0.467
Conditionals 100.0% (0/0) 💚

@orouz orouz marked this pull request as ready for review February 8, 2023 12:18
@orouz orouz requested a review from a team as a code owner February 8, 2023 12:18
@orouz orouz merged commit c2d1157 into elastic:main Feb 8, 2023
@elasticmachine
Copy link

Package cloud_security_posture - 1.2.10-beta1 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfirpeled kfirpeled kfirpeled approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orouz @elasticmachine @kfirpeled