Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1password] Enable http keep-alive#5483

Merged
andrewkroh merged 5 commits into
elastic:mainfrom
andrewkroh:1password/feature/add-keep-alive
Mar 21, 2023
Merged

[1password] Enable http keep-alive#5483
andrewkroh merged 5 commits into
elastic:mainfrom
andrewkroh:1password/feature/add-keep-alive

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Mar 8, 2023

What does this PR do?

Enable HTTP keep-alive so that the client can reusing HTTP connections. This requires Elastic Agent 8.6 because that's the version where this configuration option was added.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@andrewkroh andrewkroh added enhancement New feature or request Team:Security-External Integrations Integration:1password 1Password (Partner supported) labels Mar 8, 2023
Enable HTTP keep-alive so that the client can reusing HTTP connections.
This requires Elastic Agent 8.6 because that's the version where this configuration
option was added.
@andrewkroh andrewkroh marked this pull request as ready for review March 8, 2023 20:05
@andrewkroh andrewkroh requested a review from a team as a code owner March 8, 2023 20:05
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh changed the title [1password] - enable http keep-alive [1password] Enable http keep-alive Mar 8, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 8, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-20T13:57:11.685+0000

  • Duration: 15 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 8, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 90.909% (20/22) 👎 -2.424
Lines 92.793% (206/222) 👎 -7.207
Conditionals 100.0% (0/0) 💚

@efd6
Copy link
Copy Markdown
Contributor

efd6 commented Mar 8, 2023

Just a note for future support: beats support for this made it in to 8.6.1 (with special case for future 7.17.10 which this won't see), so it is not expected to work for 8.6.0 or before.

@andrewkroh andrewkroh merged commit a62b064 into elastic:main Mar 21, 2023
@elasticmachine
Copy link
Copy Markdown

Package 1password - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=1password

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Enable HTTP keep-alive so that the client can reuse HTTP connections.
This requires Elastic Agent 8.6.1 because that's the version where this configuration
option was added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:1password 1Password (Partner supported)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants