Thanks to visit codestin.com
Credit goes to github.com

Skip to content

all: remove confusing fail- prefix from error messages #7105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2023
Merged

all: remove confusing fail- prefix from error messages #7105

merged 1 commit into from
Jul 24, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 24, 2023 •
edited
Loading

What does this PR do?

Removes a confusing prefix from enhanced error.message fields.

This was originally added to a pipeline with a specific context of adding a machine-friendly tag to error.message, but through miscommunication was included in all subsequent extended error.message implementations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations labels Jul 24, 2023
@efd6 efd6 self-assigned this Jul 24, 2023
@efd6 efd6 force-pushed the 6919-fail_prefix branch from dd2e222 to d334d27 Compare July 24, 2023 00:06
@elasticmachine
Copy link

elasticmachine commented Jul 24, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-24T01:42:31.998+0000

  • Duration: 18 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 180
Skipped 0
Total 180

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 24, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 100.0% (61/61) 💚
Classes 100.0% (61/61) 💚
Methods 98.312% (466/474) ❕
Lines 86.231% (16320/18926) ❕
Conditionals 100.0% (0/0) 💚

@efd6 efd6 force-pushed the 6919-fail_prefix branch from d334d27 to c063676 Compare July 24, 2023 00:36
@efd6
all: remove confusing fail- prefix from error messages
6d53434 
This was originally added to a pipeline with a specific context of adding a
machine-friendly tag to error.message, but through miscommunication was included
in all subsequent extended error.message implementations.
@efd6 efd6 force-pushed the 6919-fail_prefix branch from c063676 to 6d53434 Compare July 24, 2023 01:42
@efd6 efd6 marked this pull request as ready for review July 24, 2023 02:48
@efd6 efd6 requested a review from a team as a code owner July 24, 2023 02:48
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

taylor-swanson
taylor-swanson approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 35c7c40 into elastic:main Jul 24, 2023
@elasticmachine
Copy link

Package bitwarden - 1.0.1 containing this change is available at https://epr.elastic.co/search?package=bitwarden

@elasticmachine
Copy link

Package cisco_nexus - 0.14.2 containing this change is available at https://epr.elastic.co/search?package=cisco_nexus

@elasticmachine
Copy link

Package crowdstrike - 1.16.1 containing this change is available at https://epr.elastic.co/search?package=crowdstrike

@elasticmachine
Copy link

Package juniper_srx - 1.13.1 containing this change is available at https://epr.elastic.co/search?package=juniper_srx

@elasticmachine
Copy link

Package rapid7_insightvm - 1.0.1 containing this change is available at https://epr.elastic.co/search?package=rapid7_insightvm

@elasticmachine
Copy link

Package ti_misp - 1.18.2 containing this change is available at https://epr.elastic.co/search?package=ti_misp

@elasticmachine
Copy link

Package trellix_epo_cloud - 1.0.2 containing this change is available at https://epr.elastic.co/search?package=trellix_epo_cloud

@elasticmachine
Copy link

Package vectra_detect - 1.0.1 containing this change is available at https://epr.elastic.co/search?package=vectra_detect

@efd6 efd6 deleted the 6919-fail_prefix branch February 5, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@taylor-swanson taylor-swanson taylor-swanson approved these changes

Assignees

@efd6 efd6

Labels
bug Something isn't working, use only for issues Integration:bitwarden Bitwarden Integration:cisco_nexus Cisco Nexus Integration:crowdstrike CrowdStrike Integration:juniper_srx Juniper SRX Integration:rapid7_insightvm Rapid7 InsightVM Integration:sentinel_one_cloud_funnel SentinelOne Cloud Funnel Integration:ti_misp MISP Integration:trellix_epo_cloud Trellix ePO Cloud Integration:vectra_detect Vectra Detect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efd6 @elasticmachine @andrewkroh @taylor-swanson