Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[O11y][Springboot] Resolve the conflicts in host.ip field, update readme and remove incorrect rename processor #7888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 28, 2023
Merged

[O11y][Springboot] Resolve the conflicts in host.ip field, update readme and remove incorrect rename processor #7888

merged 3 commits into from
Sep 28, 2023

Conversation

milan-elastic
Copy link
Contributor

@milan-elastic milan-elastic commented Sep 20, 2023 •
edited
Loading

  • Bug

What does this PR do?

  • Added host.ip field in ecs.yml and added re-indexing steps to resolve conflicts for existing users.
  • Updating the Readme.md with the instruction on how user can monitor their application with following functions: InMemoryHttpTraceRepository
    InMemoryAuditEventRepository
  • Remove the incorrect rename processor from the memory datastream pipeline

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Related issues

@milan-elastic milan-elastic added Integration:spring_boot Spring Boot bugfix Pull request that fixes a bug issue labels Sep 20, 2023
@milan-elastic milan-elastic self-assigned this Sep 20, 2023
@milan-elastic milan-elastic changed the title [O11y][SpringBoot] Resolve the conflicts in host.ip field and Update Readme [O11y][Springboot] Resolve the conflicts in host.ip field and Update Readme Sep 20, 2023
@milan-elastic milan-elastic marked this pull request as ready for review September 20, 2023 12:57
@milan-elastic milan-elastic requested a review from a team as a code owner September 20, 2023 12:57
@elasticmachine
Copy link

elasticmachine commented Sep 20, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-27T11:11:58.501+0000

  • Duration: 20 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 0
Total 33

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 20, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 100.0% (27/27) 💚 7.865
Lines 93.464% (143/153) 👎 -1.403
Conditionals 100.0% (0/0) 💚

@milan-elastic milan-elastic changed the title [O11y][Springboot] Resolve the conflicts in host.ip field and Update Readme [O11y][Springboot] Resolve the conflicts in host.ip field, update readme and remove incorrect rename processor Sep 27, 2023
ishleenk17
ishleenk17 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@milan-elastic milan-elastic merged commit e64d9b9 into elastic:main Sep 28, 2023
@elasticmachine
Copy link

Package spring_boot - 0.11.1 containing this change is available at https://epr.elastic.co/search?package=spring_boot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishleenk17 ishleenk17 ishleenk17 approved these changes

+1 more reviewer

@harnish-crest-data harnish-crest-data harnish-crest-data approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@milan-elastic milan-elastic

Labels
bugfix Pull request that fixes a bug issue Integration:spring_boot Spring Boot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][Springboot] Remove incorrect rename processor [O11y][Springboot] Update README [O11y][Springboot] Conflicts in host.ip field
4 participants
@milan-elastic @elasticmachine @ishleenk17 @harnish-crest-data