Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Cloud Security] Assign default GCP account type #8228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2023
Merged

[Cloud Security] Assign default GCP account type #8228

merged 2 commits into from
Oct 17, 2023

Conversation

jeniawhite
Copy link
Contributor

@jeniawhite jeniawhite commented Oct 17, 2023 •
edited
Loading

Proposed commit message

In order to have a working GCP integration, we are required to have an account type.
Older integrations did not have this value, this caused a breaking change.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@jeniawhite jeniawhite requested a review from a team as a code owner October 17, 2023 12:54
@jeniawhite jeniawhite changed the title [cloud_security_posture] Assign default GCP account type [Cloud Security] Assign default GCP account type Oct 17, 2023
@jeniawhite jeniawhite added bug Something isn't working, use only for issues Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] labels Oct 17, 2023
@elasticmachine
Copy link

elasticmachine commented Oct 17, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-17T12:56:30.655+0000

  • Duration: 15 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👎 -66.463
Lines 100.0% (0/0) 💚 3.688
Conditionals 100.0% (0/0) 💚

@jeniawhite jeniawhite merged commit 1c150f8 into elastic:main Oct 17, 2023
@elasticmachine
Copy link

Package cloud_security_posture - 1.6.4-preview1 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@jeniawhite jeniawhite mentioned this pull request Oct 18, 2023
Closed
4 tasks
jeniawhite added a commit to jeniawhite/integrations that referenced this pull request Oct 18, 2023
@jeniawhite
Revert "[Cloud Security] Assign default GCP account type (elastic#8228)"
9d78911 
This reverts commit 1c150f8.
@elasticmachine
Copy link

Package cloud_security_posture - 1.6.4 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oren-zohar oren-zohar oren-zohar approved these changes

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues Integration:cloud_security_posture Security Posture Management Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud Security] CSPM GCP migration to multi-account config is broken
4 participants
@jeniawhite @elasticmachine @oren-zohar @andrewkroh