Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[cloud_security_posture] GCP OrganizationId must be string #8300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2023
Merged

[cloud_security_posture] GCP OrganizationId must be string #8300

merged 2 commits into from
Oct 26, 2023

Conversation

amirbenun
Copy link
Contributor

@amirbenun amirbenun commented Oct 26, 2023 •
edited
Loading

Proposed commit message

The GCP Organization ID must be explicitly passed to the agent as string to avoid parsing issues.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@amirbenun amirbenun added the bug Something isn't working, use only for issues label Oct 26, 2023
@amirbenun amirbenun requested a review from a team as a code owner October 26, 2023 10:51
@elasticmachine
Copy link

elasticmachine commented Oct 26, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-26T10:52:06.881+0000

  • Duration: 17 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👎 -59.722
Lines 100.0% (0/0) 💚 3.386
Conditionals 100.0% (0/0) 💚

@amirbenun amirbenun merged commit c856d61 into elastic:main Oct 26, 2023
@amirbenun amirbenun deleted the csp-gcp-org-str branch October 26, 2023 11:37
@elasticmachine
Copy link

Package cloud_security_posture - 1.6.5 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oren-zohar oren-zohar oren-zohar approved these changes

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues Integration:cloud_security_posture Security Posture Management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amirbenun @elasticmachine @oren-zohar @andrewkroh