Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[O11y][Spring Boot] Update README to use documentation guidelines. #9070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 13, 2024
Merged

[O11y][Spring Boot] Update README to use documentation guidelines. #9070

merged 8 commits into from
Feb 13, 2024

Conversation

harnish-crest-data
Copy link
Contributor

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@harnish-crest-data harnish-crest-data added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request labels Feb 6, 2024
@harnish-crest-data harnish-crest-data self-assigned this Feb 6, 2024
@elasticmachine
Copy link

elasticmachine commented Feb 6, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@harnish-crest-data harnish-crest-data marked this pull request as ready for review February 7, 2024 04:57
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner February 7, 2024 04:57
kush-elastic
kush-elastic approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-crest-data harnish-crest-data force-pushed the spring_boot-update-readme-as-per-guidelines branch from 9e905ed to ed267ee Compare February 7, 2024 12:03
alaudazzi
alaudazzi requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments are integrated.

alaudazzi
alaudazzi approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devamanv
devamanv reviewed Feb 9, 2024
View reviewed changes
devamanv
devamanv approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harnish-crest-data
resolve merge conflicts
2a77698 
	packages/spring_boot/manifest.yml
@harnish-crest-data harnish-crest-data enabled auto-merge (squash) February 13, 2024 09:08
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @harnish-elastic

@harnish-crest-data harnish-crest-data merged commit ba8c747 into elastic:main Feb 13, 2024
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

Package spring_boot - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=spring_boot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devamanv devamanv devamanv approved these changes

@alaudazzi alaudazzi alaudazzi approved these changes

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@harnish-crest-data harnish-crest-data

Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:spring_boot Spring Boot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply the Integrations doc template to Spring Boot
6 participants
@harnish-crest-data @elasticmachine @devamanv @alaudazzi @kush-elastic @andrewkroh