Add support for timeslice metrics indicator #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for the resource based on OpenAPI docs. * Add tests * Generate docs
* Fix up missing fields
* Remove check for equations
lloydmeta
commented
Jul 9, 2025
lloydmeta
commented
Jul 9, 2025
lloydmeta
commented
Jul 9, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the timeslice_metric_indicator type in the Terraform provider for Elasticsearch/Kibana SLO resources. The implementation enables users to create SLOs with timeslice-based metrics that evaluate conditions across time windows.
Key changes:
- Added the
timeslice_metric_indicatorschema and handling logic with support for various metric aggregations - Implemented comprehensive test coverage for different metric types (basic, percentile, doc_count, and mixed metrics)
- Updated documentation and examples to include the new timeslice metric indicator
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
internal/kibana/slo.go |
Added timeslice metric indicator schema, serialization, and deserialization logic |
internal/kibana/slo_test.go |
Added comprehensive test coverage for all timeslice metric indicator scenarios |
internal/clients/kibana/slo.go |
Added support for timeslice metric in response-to-request indicator conversion |
examples/resources/elasticstack_kibana_slo/resource.tf |
Added example configuration for timeslice metric indicator |
docs/resources/kibana_slo.md |
Added documentation for the new timeslice metric indicator schema |
* Fix up filter sourcing and add tests Signed-off-by: lloydmeta <[email protected]>
96c6bbe to
bc991a8
Compare
lloydmeta
commented
Jul 10, 2025
tobio
reviewed
Jul 10, 2025
8 tasks
tobio
added a commit
that referenced
this pull request
Jul 18, 2025
* origin/main: Fix master timeout for serverless flavor (#1207) Add reroute processor data source for Elasticsearch ingest pipelines (#1204) chore(deps): update golang docker tag to v1.24.5 (#1202) chore(deps): update dependency go to v1.24.5 (#1200) Add support for timeslice metrics indicator (#1195)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #814