Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: allow dependency changes from non-maintainers with label #42830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

samuelmaddock
Copy link
Member

@samuelmaddock samuelmaddock commented Jul 8, 2024

Sometimes dependency changes might be necessary from non-maintainers. See #42001 (comment)

Adds a conditional which skips this check when allow-dependency-change is an added label.

Release Notes

Notes: none

Bypass dependency change causing auto-close when `allow-dependency-change` label is added.
@samuelmaddock samuelmaddock requested a review from dsanders11 July 8, 2024 18:52
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 8, 2024
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This policy should not be overridden rather we should find a way to ensure this can be done safely under the existing policy.

For instance, ensuring that the diff in yarn.lock is entirely committed by a maintainer and allowing maintainers to push to the PR.

@samuelmaddock
Copy link
Member Author

closing in favor of #42855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants