Merged
Conversation
ec4f1e5 to
49e5332
Compare
dsanders11
approved these changes
Jan 16, 2026
Member
dsanders11
left a comment
There was a problem hiding this comment.
Has a patch conflict due to the patch changes on main, but otherwise LGTM.
49e5332 to
787ba96
Compare
787ba96 to
0d31797
Compare
0d31797 to
5c7ecaf
Compare
|
No Release Notes |
Contributor
|
I was unable to backport this PR to "38-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "39-x-y" cleanly; |
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #49431 |
Contributor
|
@codebytere Did Electron use these methods? Will removing these private APIs have any consequences? |
|
@codebytere Hi, thanks for fixing this issue! Could you please let me know in which release this fix will be included, and approximately when that release will be published? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #49386
Preprocesses out unguarded private API usages on macOS:
_toolbarView✅_menuImpl_removeFromGroups:✅_isConsideredOpenForPersistentState✅_boundsIfOpen✅_resizeDirectionForMouseLocation:✅NSAppendToKillRing✅kCFBundleNumericVersionKey✅__NSNewKillRingSequence✅_CGSSetWindowCaptureExcludeShape🔴 Removed Upstream_CGRegionCreateWithRect🔴 Removed Upstream_CTFontCopyVariationAxesInternal🔴 Removed Upstream__NSInitializeKillRing✅NSYankFromKillRing✅NSSetKillRingToYankedState✅Checklist
npm testpassesRelease Notes
Notes: none