This repository was archived by the owner on Dec 5, 2022. It is now read-only.
feat: add a command-line-interface for launching #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@codebytere had a great idea: what if we could install and launch the demos app right from the command line?!
This change moves us in that direction:
nameto be a valid npm package nameprivateso package can be published to npmbinscriptOnce we publish this, folks should be able to run the demos app with
npx electron-api-demos.Caveat: this approach will essentially be running the application in "dev" mode, as if you were downloading the repo and running
npm install && npm start. So the app icon will be the stock Electron icon, and the behavior of the app maybe be slightly different if there are an "dev vs packaged" checks in the code.