fix(core-utils): startLogic was called in incorrect context#3809
Merged
erickzhao merged 2 commits intoelectron:mainfrom Aug 27, 2025
Merged
fix(core-utils): startLogic was called in incorrect context#3809erickzhao merged 2 commits intoelectron:mainfrom
erickzhao merged 2 commits intoelectron:mainfrom
Conversation
BlackHole1
approved these changes
Mar 11, 2025
erikian
reviewed
Mar 21, 2025
Member
erikian
left a comment
There was a problem hiding this comment.
Could you elaborate on what's the behavior before / after this change? Is this something that can be tested in some way?
Contributor
Author
|
The sample code for writing plugins in the documentation currently doesn't work, this change will make it work. From https://www.electronforge.io/advanced/extending-electron-forge/writing-plugins export default class MyPlugin extends Pluginbase {
async startLogic (opts) {
await this.compileMainProcess();
return null;
}
compileMainProcess () { /* ... */ }
}
The official plugin uses all arrow functions, which is fine, but the documentation uses named functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Fixed startLogic being called in incorrect context.