fix: types for nativeImage, webContents, webFrameMain again #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes electron#110. Signed-off-by: Anders Kaseorg <[email protected]>
ShareMenu and webFrameMain are new in Electron 12. Signed-off-by: Anders Kaseorg <[email protected]>
Contributor
Author
|
Added some commits that, in combination with #113, will let us catch future |
This was previously excluded (electron#48) because of CI failures due to index.d.ts referencing files in dist. Those references were later removed (electron#58), so we can include it again to have CI verify that index.d.ts type checks. Signed-off-by: Anders Kaseorg <[email protected]>
Contributor
Author
|
@nornagon Do I need to do anything to help get this fix merged? |
nornagon
approved these changes
Mar 15, 2022
|
🎉 This PR is included in version 2.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110.